add passthrough equality to RxRef

tim-smart · Sep 25, 2023 · 0b3f2c5 · 0b3f2c5
1 parent ab3d68f
commit 0b3f2c5
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 2 deletions.
diff --git a/.changeset/soft-clocks-smell.md b/.changeset/soft-clocks-smell.md
@@ -0,0 +1,5 @@
+---
+"@effect-rx/rx": patch
+---
+
+add passthrough equality to RxRef
diff --git a/docs/rx/RxRef.ts.md b/docs/rx/RxRef.ts.md
@@ -69,7 +69,7 @@ Added in v1.0.0
 **Signature**
 
 ```ts
-export interface ReadonlyRef<A> {
+export interface ReadonlyRef<A> extends Equal.Equal {
   readonly [TypeId]: TypeId
   readonly key: string
   readonly value: A

diff --git a/packages/rx/src/RxRef.ts b/packages/rx/src/RxRef.ts
@@ -3,6 +3,7 @@
  */
 import * as Equal from "@effect/data/Equal"
 import { globalValue } from "@effect/data/GlobalValue"
+import * as Hash from "@effect/data/Hash"
 
 /**
  * @since 1.0.0
@@ -20,7 +21,7 @@ export type TypeId = typeof TypeId
  * @since 1.0.0
  * @category models
  */
-export interface ReadonlyRef<A> {
+export interface ReadonlyRef<A> extends Equal.Equal {
   readonly [TypeId]: TypeId
   readonly key: string
   readonly value: A
@@ -73,6 +74,15 @@ class ReadonlyRefImpl<A> implements ReadonlyRef<A> {
   constructor(public value: A) {
     this[TypeId] = TypeId
   }
+
+  [Equal.symbol](that: ReadonlyRef<A>) {
+    return Equal.equals(this.value, that.value)
+  }
+
+  [Hash.symbol]() {
+    return Hash.hash(this.value)
+  }
+
   listeners: Array<(a: A) => void> = []
   listenerCount = 0
 
@@ -122,6 +132,12 @@ class MapRefImpl<A, B> implements ReadonlyRef<B> {
   constructor(readonly parent: ReadonlyRef<A>, readonly transform: (a: A) => B) {
     this[TypeId] = TypeId
   }
+  [Equal.symbol](that: ReadonlyRef<A>) {
+    return Equal.equals(this.value, that.value)
+  }
+  [Hash.symbol]() {
+    return Hash.hash(this.value)
+  }
   get value() {
     return this.transform(this.parent.value)
   }