support arrays in RxRef.prop

.changeset/yellow-points-decide.md

@@ -0,0 +1,5 @@
+---
+"@effect-rx/rx": patch
+---
+
+support arrays in RxRef.prop

packages/rx/src/RxRef.ts

@@ -194,17 +194,29 @@ class PropRefImpl<A, K extends keyof A> implements RxRef<A[K]> {
     return new PropRefImpl(this, prop)
   }
   set(value: A[K]): RxRef<A[K]> {
-    this.parent.set({
-      ...this.parent.value,
-      [this._prop]: value
-    })
+    if (Array.isArray(this.parent.value)) {
+      const newArray = this.parent.value.slice()
+      newArray[this._prop as number] = value
+      this.parent.set(newArray as A)
+    } else {
+      this.parent.set({
+        ...this.parent.value,
+        [this._prop]: value
+      })
+    }
     return this
   }
   update(f: (value: A[K]) => A[K]): RxRef<A[K]> {
-    this.parent.set({
-      ...this.parent.value,
-      [this._prop]: f(this.parent.value[this._prop])
-    })
+    if (Array.isArray(this.parent.value)) {
+      const newArray = this.parent.value.slice()
+      newArray[this._prop as number] = f(this.parent.value[this._prop])
+      this.parent.set(newArray as A)
+    } else {
+      this.parent.set({
+        ...this.parent.value,
+        [this._prop]: f(this.parent.value[this._prop])
+      })
+    }
     return this
   }
 }

packages/rx/test/RxRef.test.ts

@@ -20,30 +20,60 @@ describe("RxRef", () => {
       ref.set(0)
       assert.deepEqual(updates, [-1, -2, -3])
     })
+  })
 
-    test("prop", () => {
-      const parent = RxRef.make({
-        a: 0,
-        b: 1,
-        c: 2
-      })
-      const ref = parent.prop("a")
+  test("prop", () => {
+    const parent = RxRef.make({
+      a: 0,
+      b: 1,
+      c: 2
+    })
+    const ref = parent.prop("a")
 
-      const updates: Array<number> = []
-      const cancel = ref.subscribe((_) => updates.push(_))
+    const updates: Array<number> = []
+    const cancel = ref.subscribe((_) => updates.push(_))
 
-      parent.update((_) => ({ ..._, a: -1 }))
-      parent.update((_) => ({ ..._, b: -2 }))
+    parent.update((_) => ({ ..._, a: -1 }))
+    parent.update((_) => ({ ..._, b: -2 }))
 
-      assert.deepEqual(updates, [-1])
+    assert.deepEqual(updates, [-1])
 
-      ref.set(0)
+    ref.set(0)
 
-      assert.deepEqual(updates, [-1, 0])
-      assert.deepEqual(parent.value, { a: 0, b: -2, c: 2 })
+    assert.deepEqual(updates, [-1, 0])
+    assert.deepEqual(parent.value, { a: 0, b: -2, c: 2 })
 
-      cancel()
+    cancel()
+  })
+
+  test("prop nested array", () => {
+    const parent = RxRef.make({
+      a: 0,
+      b: 1,
+      c: {
+        d: [{
+          e: 2
+        }]
+      }
     })
+    const ref = parent.prop("c").prop("d").prop(0).prop("e")
+
+    const updates: Array<any> = []
+    const cancel = parent.subscribe((_) => updates.push(_))
+
+    ref.set(3)
+
+    assert.deepStrictEqual(updates, [{
+      a: 0,
+      b: 1,
+      c: {
+        d: [{
+          e: 3
+        }]
+      }
+    }])
+
+    cancel()
   })
 
   describe("collection", () => {