Feat/Result.match #108
Merged
Feat/Result.match #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-smart
requested changes
Feb 28, 2024
packages/rx/src/Result.ts
Outdated
| * @category combinators | ||
| */ | ||
| export const match: { | ||
| <A, E, Ret>(options: MatchOptions<A, E, Ret>): (self: Result<A, E>) => Ret |
There was a problem hiding this comment.
I think inlining the options is ok.
options: {
readonly onInitial: (_: Initial<A, E>) => X
readonly onFailure: (_: Failure<A, E>) => Y
readonly onSuccess: (_: Success<A, E>) => Z
}There was a problem hiding this comment.
How do you mean? Instead of having a MatchOptions interface? It's used in multiple places though. What about just not exporting it?
There was a problem hiding this comment.
Similar to how .match is usually implemented in the effect modules: https://effect-ts.github.io/effect/effect/Either.ts.html#match
There was a problem hiding this comment.
It just means the type signature is more obvious at a glance, instead of having to jump to the interface to see all the options.
There was a problem hiding this comment.
Ah gotcha. Makes sense. Updated :)
jessekelly881
force-pushed
the
feat/Result.match
branch
from
131dd71
to
1834e6d
Compare
jessekelly881
force-pushed
the
feat/Result.match
branch
from
1834e6d
to
c83595d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Result.match helper and ran docgen.