feat: Add i18n (FR language) + l10n (calendar + currency formatting) #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim-smart
force-pushed
the
feat/i18n-l10n
branch
from
7c635cb
to
86d3048
Compare
|
Thanks! If you can add the remaining translations for the menu in another PR that would be great. I'll push out a beta release on the Play store soon. |
Yes I'll get round to that shortly, just need to work out how to use i18n inside an enum ! Thanks for merging and for future release :) |
|
I have already solved that for you, the only thing missing now is the translations. |
|
Sorry I didn't notice your commits on top of the PR, thanks for that, I'll add the translations right away |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @tim-smart,
I've started to work on a few suggestions from issue #19:
Also changed the "Toggle flash" button to an icon button (the french translation is pretty long)
I'm new to Flutter and Dart so I've probably done a few things wrong, but I'm interested in your feedback. I've only been able to test on an Android device.
Here are some screenshots:
Date picker in french with week starting on monday:
Euro currency + french number formatting:
"Toggle flash" button replaced with flash icon:
French language in new voucher form: