Stop preconditions from being executed twice

[lstrzebinczyk]

When running an action with #try_perform!, preconditions are being run twice. This PR fixes this.

https://github.com/toptal/platform/pull/78833 is a platform PR run against this patch, with successfull unit tests and features:

How to test

• fetch platform branch of https://github.com/toptal/platform/pull/78833
• open console
• enter this class into console:

class TestAction < BaseAction 
  precondition do
    puts "RUNNING PRECONDITION"
  end

  subject :role_step
  
  history false

  private

  def execute_perform!(*)
  end
end

• run TestAction.as_system.new(RoleStep.new).try_perform!
• in your console, you should see RUNNING PRECONDITION twice
• run the same on master, you'll see it twice.

Review

• Document code according to Getting Started with Yard.
• All tests are passing.
• Test manually.
• Get approval.

Pre-merge checklist

• The PR relates to a single subject with a clear title and description in grammatically correct, complete sentences.
• Verify that feature branch is up-to-date with master (if not - rebase it).
• Double check the quality of commit messages.
• Squash related commits together.

[lstrzebinczyk]

@toptal-anvil ping reviewers

[catks]

I think it would be good to add a new spec to ensure the preconditions are only called once, I think you can call a spy/mock in

granite/spec/lib/granite/action/performing_spec.rb

Line 15 in d1fecea

precondition { decline_with(:message) if login == '' }

and then check is only called once in after perform

[lstrzebinczyk]

Spec added 👍

[lstrzebinczyk]

@toptal-anvil ping reviewers

[lstrzebinczyk]

@toptal-anvil ping reviewers

[lstrzebinczyk]

I've converted to draft to hide from seal. I'll get back to this once I have a moment, or after oncall