NAS-131449 / 24.10-RC.1 / fix bug in deprecated service detection (by yocalebo)

[bugclerk]

I'm not even really sure how this has worked in the first place....QE has a system (running 24.04.2.2) with a Gold license that they're manually upgrading to what will be EE-RC.1. They're met with a deprecation message and the update fails. After investigation, I'm not sure how this has ever worked....

The system they had was running minio which produced a running service name of minio but the crgroup entry was

0::/kubepods.slice/kubepods-burstable.slice/kubepods-burstable pod3c3941c1_24e7_4189_854f_f9dfcfa638ef.slice/cri-containerd-14ef8d9c8a76f8c8f1731bd455062481c4e03f683fe52566bbc4fc74f480225.scope

I went ahead and installed webdav app and also saw it produce an entry like so

0::/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podf905dab1_0a2c_4e68_9d0c_861da1874869.slice/cri-containerd-660a2b0eb91bc45f92b245099be5b2d27686d2e29329bc2eeeedc8f4a0b951e0.scope

This means we're tripping the deprecation service logic rather easily and after looking at it for a bit, I'm not sure how we were ever doing this properly 🤔 Anyways, I've added the kubepod string as another check to prevent these false positive alerts.

Original PR: #733
Jira URL: https://ixsystems.atlassian.net/browse/NAS-131449

[bugclerk]

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.