Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131403 / 25.04 / Use app.redeploy endpoint for restart apps #10760

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

denysbutenko
Copy link
Member

Changes:

Replace custom implementation.

Testing:

You can test it on the app widget on main dashboard

@denysbutenko denysbutenko requested a review from a team as a code owner September 27, 2024 09:47
@denysbutenko denysbutenko requested review from RehanY147 and removed request for a team September 27, 2024 09:47
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131403: Use app.redeploy endpoint for restart apps NAS-131403 / 25.04 / Use app.redeploy endpoint for restart apps Sep 27, 2024
Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add this operation to the apps dashboard installed apps table. It's missing from there.

@denysbutenko
Copy link
Member Author

Let's add this operation to the apps dashboard installed apps table. It's missing from there.

Good idea, added

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (303e5cc) to head (8cd0290).

Files with missing lines Patch % Lines
...ponents/installed-apps/installed-apps.component.ts 20.00% 8 Missing ⚠️
...onents/installed-apps/app-row/app-row.component.ts 33.33% 2 Missing ⚠️
...rc/app/pages/apps/services/applications.service.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #10760   +/-   ##
=======================================
  Coverage   80.91%   80.91%           
=======================================
  Files        1571     1571           
  Lines       52114    52116    +2     
  Branches     5812     5808    -4     
=======================================
+ Hits        42167    42169    +2     
  Misses       9947     9947           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Table styles got messed up

Screen.Recording.2024-10-02.at.2.39.35.AM.mov

Copy link
Contributor

@RehanY147 RehanY147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants