Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Add Contentful to website build process #1204

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

davidnguyen88
Copy link
Contributor

@davidnguyen88 davidnguyen88 commented Mar 23, 2022

@davidmurdoch
Copy link
Member

Build is failing. Can you fix it and ping me when it's working?

@davidmurdoch
Copy link
Member

At first glance this seems to remove the ability for us to create reproducible website builds. There seems to be no way to track changes to content over time I think it is very important for our website content to be transparent and auditable by the community.

Is it possible to manage content in Contentful but automatically mirror that content here on GitHub?

@davidnguyen88
Copy link
Contributor Author

davidnguyen88 commented Mar 24, 2022

Build is failing. Can you fix it and ping me when it's working?

Hi @davidmurdoch,
Please go to fleek-ci and update the build command to add the contentful and python-dotenv module.
Replace 'pip install mkdocs-awesome-pages-plugin mkdocs-macros-plugin mkdocs-minify-plugin requests mkdocs-static-i18n && mkdocs build' to 'pip install mkdocs-awesome-pages-plugin mkdocs-macros-plugin mkdocs-minify-plugin requests mkdocs-static-i18n contentful python-dotenv && mkdocs build'

@davidmurdoch
Copy link
Member

@kevinbluer I'm pretty sure I have a fleek account, but when I signed in with the two accounts I know I have and did see the Truffle account under either of them. :-/ Can you take a look to see if I'm added to the team, and if not, add me?

@kevinbluer
Copy link
Member

hey @davidmurdoch, invite on the way 👍

@gnidan gnidan changed the title Dx team/issues/970 integration with Contentful Add Contentful to website build process Mar 30, 2022
@davidmurdoch
Copy link
Member

I think some changes need to be made to this integration. It must to be impossible for the website "Build Preview" (i.e., the contents of the PR itself) to differ from what gets built once the PR is merged. So the Contentful integration probably needs to push all relevant data to a GitHub PR, so we can properly review the changes here, rather than just trust that whatever the preview says is what the actual content is (we also need to approve any changes via PR first).

Also, at first glance it looks like there might be changes and modules added here that aren't used (like github-list, for example?)

And just a heads up: I think all members of trufflesuite will need a Contentful account before this gets merged (@gnidan your thoughts on this would be appreciated), and we'll need to add Contentful to a onboarding process.

@jlazoff
Copy link
Contributor

jlazoff commented May 23, 2022

I think some changes need to be made to this integration. It must to be impossible for the website "Build Preview" (i.e., the contents of the PR itself) to differ from what gets built once the PR is merged. So the Contentful integration probably needs to push all relevant data to a GitHub PR, so we can properly review the changes here, rather than just trust that whatever the preview says is what the actual content is (we also need to approve any changes via PR first).

Also, at first glance it looks like there might be changes and modules added here that aren't used (like github-list, for example?)

And just a heads up: I think all members of trufflesuite will need a Contentful account before this gets merged (@gnidan your thoughts on this would be appreciated), and we'll need to add Contentful to a onboarding process.

Hi @davidnguyen88 @cuonglt-ync ,

Can you help @davidmurdoch with the above?

@cuonglt-ync
Copy link

#1204 (comment)
=> It is still fleek CI build failed so that you can not review (due to dependence). Can you check?

Copy link
Member

@davidmurdoch davidmurdoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some changes need to be made to this integration. It must to be impossible for the website "Build Preview" (i.e., the contents of the PR itself) to differ from what gets built once the PR is merged. So the Contentful integration probably needs to push all relevant data to a GitHub PR, so we can properly review the changes here, rather than just trust that whatever the preview says is what the actual content is (we also need to approve any changes via PR first).

Also, at first glance it looks like there might be changes and modules added here that aren't used (like github-list, for example?)

And just a heads up: I think all members of trufflesuite will need a Contentful account before this gets merged (@gnidan your thoughts on this would be appreciated), and we'll need to add Contentful to a onboarding process.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants