フィルタ設定への説明とガイドを追加 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Closed
azrsh
reviewed
Dec 10, 2022
Comment on lines
+1
to
+2
| export const MANABA_COURSES_LIST_URL = | ||
| 'https://manaba.tsukuba.ac.jp/ct/home_course?chglistformat=list' |
There was a problem hiding this comment.
この PR でやらなくてもいいけど定数を切り出すならこの辺も対応した方が良さそう
There was a problem hiding this comment.
あと定数を切り出す先のディレクトリが config/ 以下なのには何か理由がある？
Comment on lines
+83
to
+85
| <Button color="secondary" onClick={handleGoingCourseListButtonClick}> | ||
| コース一覧ページへ | ||
| </Button> |
There was a problem hiding this comment.
https://mui.com/material-ui/react-button/#text-button のように hrefをセットすれば onClick でハンドルする必要はなさそう
Comment on lines
-72
to
+121
| <Button | ||
| color="secondary" | ||
| onClick={async () => { | ||
| setEditBlackList(true) | ||
| await writeStorage('special-notify:black-list-feature', true) | ||
| updateBlackListFeatureNotify(true) | ||
| }} | ||
| > | ||
| 設定する | ||
| </Button> | ||
| <> | ||
| <Button color="primary" onClick={handleSettingButtonClick}> | ||
| 設定する | ||
| </Button> | ||
| <Button | ||
| color="secondary" | ||
| onClick={handleNoLongerDisplayButtonClick} | ||
| > | ||
| もう表示しない | ||
| </Button> | ||
| </> |
There was a problem hiding this comment.
📝 設定しないでももう表示しないを選択できるように変更している
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
背景
Resovles #43
上記 Issue にあるようにフィルタ設定にバグはなかったが、フィルタ設定は特定の画面ではないと発動しなかったため、バグのように思えてわかりにくかった。
変更
フィルタ設定ができない画面でメッセージが表示されても
フィルタ設定ができる画面への誘導が促され
該当ページでもう一度「設定」を押すと
無事フィルタ設定が編集できる
