Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteAuthenticationのRPCを追加 #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hayato24s
Copy link
Contributor

@hayato24s hayato24s commented Aug 13, 2023

DeleteAuthenticationのRPCを追加しました。

DB上のユニーク制約

user_authenticationsテーブルに対して(provider,social_id)(user_id,provider)を付与してみたのですがどうでしょうか?

ALTER TABLE user_authentications ADD CONSTRAINT uq_user_authentications_provider_social_id UNIQUE (provider, social_id);

ALTER TABLE user_authentications ADD CONSTRAINT uq_user_authentications_user_id_provider UNIQUE (user_id, provider);

.proto

https://github.com/twin-te/user-service/blob/go/feature/delete-authentication/server/pb/UserService.proto

Copy link
Member

@takonasu takonasu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SQLはよいと思います!
Goの方に関しては分からずレビューができずですmm

@takonasu
Copy link
Member

@SIY1121 のレビューもお願いしますmm

Copy link
Member

@SIY1121 SIY1121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

自分もgoのレビューはできませんが、良いと思います。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants