Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not remove non-breaking spaces. Fix #333 #334

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

albig
Copy link
Contributor

@albig albig commented Feb 20, 2024

Fix #333 - do not remove non-breaking spaces

@u01jmg3
Copy link
Owner

u01jmg3 commented Feb 20, 2024

Can you rebase against master, please? I'll fix Rector on my end.

Also, does this other space removal (line 646) affect your iCal feed?

if (!$this->disableCharacterReplacement) {
$line = str_replace(array(
' ',
"\t",
"\xc2\xa0", // Non-breaking space
), ' ', $line);

@albig albig force-pushed the fix-333-non-breakable-spaces branch from bde3a26 to adc83b4 Compare February 20, 2024 16:47
@albig
Copy link
Contributor Author

albig commented Feb 20, 2024

This replacement of \xc2\xa0 into doesn't affect me. This would be & , right? The "non-breaking space" comes alone without HTML markup.

@u01jmg3
Copy link
Owner

u01jmg3 commented Feb 20, 2024

It's the whole thing, both characters - I just wanted to check anyway.

What is \xc2\ xa0?
The \xc2\xa0 is the UTF-8 representation of the unicode U+00A0 (non-breaking space), which is shown as \xa0 in the representation of the decoded Unicode string.

@u01jmg3 u01jmg3 merged commit 1bef5d9 into u01jmg3:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-breaking spaces are removed from DESCRIPTION
2 participants