Extract common steps to the script files #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enescakir
force-pushed
the
ubicloud
branch
4 times, most recently
from
d9f7b90
to
80ca0d5
Compare
enescakir
force-pushed
the
ubicloud
branch
2 times, most recently
from
0990436
to
cab186f
Compare
The new version of az cli started to throw an exception for pending downloads. Azure/azure-cli#10160 (comment)
enescakir
force-pushed
the
ubicloud
branch
7 times, most recently
from
911430a
to
90f9a56
Compare
|
Huh, why is so much added lines? Are some of the lines actually un-doing stuff done previously? |
Add nvidia-cuda-toolkit to the GPU image (#2) Add nvidia-cuda-toolkit and cuda-drivers cuda-12-4 add cudnn add cudnn to env just install cudnn
The mix-up occurred due to the force push to the base branch. I've now rebased it |
|
Now that GitHub has ARM and GPUs, we are free of making as many decisions here? |
velioglu
force-pushed
the
ubicloud
branch
2 times, most recently
from
efaa8a1
to
8d9a1bd
Compare
enescakir
force-pushed
the
ubicloud
branch
9 times, most recently
from
f3199e4
to
a07092f
Compare
enescakir
force-pushed
the
ubicloud
branch
3 times, most recently
from
ec985f6
to
38cbfc6
Compare
enescakir
force-pushed
the
ubicloud
branch
4 times, most recently
from
c72a177
to
28b6e86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each packer template has duplicate Ubicloud steps that we can extract into common script files. I've created this pull request for initial feedback. If it seems acceptable to you, I'll rebase my previous commits.