Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add access delegate method in Component #20105

Closed
wants to merge 4 commits into from
Closed

Conversation

TatuLund
Copy link
Contributor

@TatuLund TatuLund commented Oct 2, 2024

fixes #20104

Copy link

sonarcloud bot commented Oct 2, 2024

Copy link

github-actions bot commented Oct 2, 2024

Test Results

1 139 files  ± 0  1 139 suites  ±0   1h 9m 4s ⏱️ - 1m 8s
7 408 tests ± 0  7 356 ✅  -  1  50 💤 ±0  0 ❌ ±0  2 🔥 +1 
7 772 runs  +21  7 710 ✅ +18  60 💤 +2  0 ❌ ±0  2 🔥 +1 

For more details on these errors, see this check.

Results for commit 9fff3cc. ± Comparison against base commit abc0122.

@mvysny
Copy link
Member

mvysny commented Oct 2, 2024

Please make uiRef volatile, otherwise background thread may not see the most up-to-date value. Also, in javadoc, please mark the accessUI function as thread-safe (safe to be called from background threads), to give a clear indication to users

@Legioth
Copy link
Member

Legioth commented Oct 2, 2024

Denied based on fundamental reasons from an internal discussion. In short: thread safety is questionable, it encourages bad habits, it increases memory consumption universally for something that can be solved in other ways.

@Legioth Legioth closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add access method to Component that delegates Command to be run via right UI
4 participants