Skip to content

Commit

Permalink
fix linting
Browse files Browse the repository at this point in the history
  • Loading branch information
Aravindh-Raju committed Sep 25, 2023
1 parent 60bb2c5 commit b424de8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 7 deletions.
6 changes: 3 additions & 3 deletions src/vinyldns/client.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
from vinyldns.boto_request_signer import BotoRequestSigner

from vinyldns.batch_change import BatchChange, ListBatchChangeSummaries, to_review_json
from vinyldns.membership import Group, ListGroupsResponse, GroupChange, ListGroupChangesResponse, ListMembersResponse, \
ListAdminsResponse
from vinyldns.membership import Group, ListGroupsResponse, GroupChange, ListGroupChangesResponse, \
ListMembersResponse, ListAdminsResponse
from vinyldns.serdes import to_json_string
from vinyldns.zone import ListZonesResponse, ListZoneChangesResponse, Zone, ZoneChange
from vinyldns.record import ListRecordSetsResponse, ListRecordSetChangesResponse, RecordSet, RecordSetChange
Expand Down Expand Up @@ -379,7 +379,7 @@ def list_group_changes(self, group_id, start_from=None, max_items=None, **kwargs
response, data = self.__make_request(url, u'GET', self.headers, **kwargs)

return ListGroupChangesResponse.from_dict(data)

def get_group_change(self, group_change_id, **kwargs):
"""
Get a group change.
Expand Down
12 changes: 8 additions & 4 deletions tests/test_membership.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,10 @@ def test_list_group_admins(mocked_responses, vinyldns_client):


def test_list_group_changes(mocked_responses, vinyldns_client):
change1 = GroupChange(sample_group, 'Create', 'user', None, 'id', datetime.datetime.utcnow(), 'test200', 'Group Created.')
change2 = GroupChange(sample_group2, 'Update', 'user', sample_group, 'id2', datetime.datetime.utcnow(), 'test200', 'Group name changed to \'ok2\'.')
change1 = GroupChange(sample_group, 'Create', 'user', None, 'id', datetime.datetime.utcnow(), 'test200',
'Group Created.')
change2 = GroupChange(sample_group2, 'Update', 'user', sample_group, 'id2', datetime.datetime.utcnow(),
'test200', 'Group name changed to \'ok2\'.')
lgcr = ListGroupChangesResponse([change1, change2], 'start', 'next', 100)
mocked_responses.add(
responses.GET, 'http://test.com/groups/foo/activity?startFrom=start&maxItems=100',
Expand All @@ -168,8 +170,10 @@ def test_list_group_changes(mocked_responses, vinyldns_client):
check_groups_are_same(l.new_group, r.new_group)
check_groups_are_same(l.old_group, r.old_group)


def test_get_group_change(mocked_responses, vinyldns_client):
change = GroupChange(sample_group, 'Create', 'user', None, 'id', datetime.datetime.utcnow(), 'test200', 'Group Created.')
change = GroupChange(sample_group, 'Create', 'user', None, 'id', datetime.datetime.utcnow(),
'test200', 'Group Created.')
mocked_responses.add(
responses.GET, 'http://test.com/groups/change/123',
body=to_json_string(change), status=200)
Expand All @@ -180,7 +184,7 @@ def test_get_group_change(mocked_responses, vinyldns_client):
assert r.created == change.created
assert r.user_name == change.user_name
assert r.group_change_message == change.group_change_message


def test_group_serdes():
r = from_json_string(to_json_string(sample_group), Group.from_dict)
Expand Down

0 comments on commit b424de8

Please sign in to comment.