Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to manage internal pause image #63

Closed
wants to merge 1 commit into from

Conversation

rwaffen
Copy link
Sponsor Member

@rwaffen rwaffen commented Jul 6, 2023

internal pause image is pulled directly from the internet, this does not work on air gapped nodes.
adding a parameter to pull it from a custom location

@rwaffen rwaffen requested a review from ananace July 6, 2023 08:48
@ananace
Copy link
Member

ananace commented Jul 6, 2023

I'm still not sure to what degree additional arguments should be split out into separated parameters, since the code already supports doing this by using the arguments parameter;

k8s::node::kubelet::arguments:
  pod_infra_container_image: docker.io/somewhere/pause

My first version of the module - before it was called k8s - tried to handle all possible parameters, but that was a complete mess, so this incarnation only deals the the parameters that are module-specific or shared between multiple classes, with the rest left up to the user.
I still don't know where the best place to make this delineation is - between module-handled parameters and arbitrary user-provided arguments, but I get the feeling that more documentation is going to be necessary either way.

@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Jul 6, 2023

ah this is all this + $some_hash at most default-hashes. tried this the oder day on another hash and got confused. will try again with your suggestion.

@rwaffen
Copy link
Sponsor Member Author

rwaffen commented Jul 6, 2023

this works exactly like i imagined it. thx for the hind. closing here.

@rwaffen rwaffen closed this Jul 6, 2023
@rwaffen rwaffen deleted the manage_pause_image branch July 6, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants