Initial work on hiera-ifying and Puppet 8 support for standalone etcd #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaffen
approved these changes
Jul 10, 2023
smortex
reviewed
Jul 10, 2023
rwaffen
approved these changes
Nov 23, 2023
The code is ugly, but should mean that etcd can still be installed both as part of the control-plane as well as on standalone nodes
ananace
force-pushed
the
hieraify-defaults
branch
from
4cfbda3
to
66bbb18
Compare
For ease of understanding, it also accepts control-plane to describe a K8s server - since that's the name that's used internally in Kubernetes to describe the function of such a node.
bastelfreak
reviewed
Sep 24, 2024
rwaffen
approved these changes
Sep 24, 2024
bastelfreak
reviewed
Sep 25, 2024
bastelfreak
reviewed
Sep 27, 2024
bastelfreak
reviewed
Sep 27, 2024
bastelfreak
reviewed
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code is remarkably ugly, but it should allow etcd to still be installed both as part of the control-plane as well as on standalone nodes - and still participate in the same auto-configured cluster through PuppetDB.
Probably quite closely related with #61