Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow reloading config instead of restarting to reload it #265

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

simonfelding
Copy link

Pull Request (PR) description

Allow the use of reload instead of restart as it causes false reboot events in Solarwinds Orion.

This Pull Request (PR) fixes the following issues

Fixes #264

@@ -328,6 +331,7 @@
Boolean $trap_service_enable = false,
Boolean $trap_service_hasstatus = true,
Boolean $trap_service_hasrestart = true,
String[1] $service_restart = "/bin/systemctl reload $service_name",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
String[1] $service_restart = "/bin/systemctl reload $service_name",
String[1] $service_restart = "/bin/systemctl reload ${service_name}",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this will break (at least) FreeBSD support. This parameter should probably be optional, default to undef and set to this value only on systems where it makes sense through Hiera.

Co-authored-by: Kenyon Ralph <[email protected]>
@simonfelding
Copy link
Author

thanks @kenyon, I implemented your suggestion now.

@kenyon
Copy link
Member

kenyon commented Dec 1, 2023

Also need to implement @smortex's suggestion I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reload snmpd config instead of restarting service by default
3 participants