Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported OS #957

Merged
merged 7 commits into from
Jun 28, 2024
Merged

Conversation

Valantin
Copy link
Contributor

Pull Request (PR) description

Remove unsupported os

This Pull Request (PR) fixes the following issues

#954

@Valantin Valantin added this to the 11.0.0 milestone Jun 17, 2024
@Valantin Valantin marked this pull request as draft June 27, 2024 11:18
@bastelfreak
Copy link
Member

Can you please rebase against our master branch to get rid of the merge commit?

@Valantin Valantin force-pushed the del/unsupported branch 8 times, most recently from 5efacc7 to cd6af3e Compare June 28, 2024 10:57
case $facts['os']['family'] {
'RedHat': {
$majorrelease = $facts['os']['release']['major']
if (versioncmp(fact('os.release.major'), '7') >= 0 and $zabbix_version == '7.0') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use $majorrelease here

Suggested change
if (versioncmp(fact('os.release.major'), '7') >= 0 and $zabbix_version == '7.0') {
if (versioncmp($majorrelease, '7') >= 0 and $zabbix_version == '7.0') {

"7",
"8"
]
},
{
"operatingsystem": "CentOS",
"operatingsystemrelease": [
"7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I'v planned to remove EL7 code and OS in a separe PR, need to remove a lot of unused logic from manifest and spec

@bastelfreak bastelfreak merged commit f00c8c9 into voxpupuli:master Jun 28, 2024
51 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants