Improve error handling

README.md

@@ -1,6 +1,6 @@
 # @vpmedia/phaser
 
-[![npm version](https://badge.fury.io/js/@vpmedia%2Fphaser.svg?v=1.45.0)](https://badge.fury.io/js/@vpmedia%2Fphaser)
+[![npm version](https://badge.fury.io/js/@vpmedia%2Fphaser.svg?v=1.46.0)](https://badge.fury.io/js/@vpmedia%2Fphaser)
 [![Node.js CI](https://github.com/vpmedia/phaser/actions/workflows/ci.yml/badge.svg)](https://github.com/vpmedia/phaser/actions/workflows/ci.yml)
 
 @vpmedia/phaser is the modern ECMAScript port of the popular Phaser game engine v2.6.2.

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@vpmedia/phaser",
-  "version": "1.45.0",
+  "version": "1.46.0",
   "description": "@vpmedia/phaser is the modern ECMAScript port of the popular Phaser game engine v2.6.2",
   "author": "Andras Csizmadia <[email protected]> (www.vpmedia.hu)",
   "license": "MIT",

src/phaser/core/animation_manager.js

@@ -306,7 +306,7 @@ export class AnimationManager {
         this.sprite.setFrame(this.currentFrame);
       }
     } else {
-      this.game.exceptionHandler(new Error('Cannot set frame'), { key: value });
+      this.game.exceptionHandler(new Error('Cannot set frame'), { 'asset.key': value });
     }
   }
 
@@ -332,7 +332,7 @@ export class AnimationManager {
         this.sprite.setFrame(this.currentFrame);
       }
     } else {
-      this.game.exceptionHandler(new Error('Cannot set frameName'), { key: value });
+      this.game.exceptionHandler(new Error('Cannot set frameName'), { 'asset.key': value });
     }
   }
 }

src/phaser/core/game.js

@@ -145,13 +145,7 @@ export class Game {
         isWebGlReady = true;
       } catch (e) {
         isWebGlReady = false;
-        const tags = {
-          'document.readyState': document.readyState,
-          'document.hidden': document.hidden,
-          'document.visibilityState': document.visibilityState,
-          'canvas.width': this.canvas.width,
-          'canvas.height': this.canvas.height,
-        };
+        const tags = {};
         if (window.PhaserRegistry?.GL_PROGRAM_INFO_LOG) {
           tags.gl_program_log = window.PhaserRegistry.GL_PROGRAM_INFO_LOG;
         }

src/phaser/core/sound_manager.js

@@ -61,6 +61,7 @@ export class SoundManager {
       this.context === null ||
       (this.context && this.context.createGain === undefined && this.context.createGainNode === undefined)
     ) {
+      this.game.exceptionHandler(new Error('Error creating AudioContext'));
       this.noAudio = true;
       return;
     }
@@ -220,7 +221,7 @@ export class SoundManager {
             this.game.cache.decodedSound(key, buffer);
           })
           .catch((e) => {
-            this.game.exceptionHandler(e, { key });
+            this.game.exceptionHandler(e, { 'asset.key': key });
           });
       }
     }

src/phaser/display/canvas/renderer.js

@@ -42,7 +42,7 @@ export class CanvasRenderer {
     this.view = game.canvas;
     this.context = this.view.getContext('2d', { alpha: this.transparent });
     if (!this.context) {
-      throw new Error('Error creating Canvas 2D context.');
+      throw new Error('Error creating Canvas2D context');
     }
     this.refresh = true;
     this.count = 0;

src/phaser/display/display_object.js

@@ -111,7 +111,7 @@ export class DisplayObject {
     const index1 = this.getChildIndex(child);
     const index2 = this.getChildIndex(child2);
     if (index1 < 0 || index2 < 0) {
-      throw new Error('swapChildren: Both the supplied DisplayObjects must be a child of the caller.');
+      throw new Error('swapChildren: Both the supplied DisplayObjects must be a child of the caller');
     }
     this.children[index1] = child2;
     this.children[index2] = child;

src/phaser/display/webgl/renderer.js

@@ -128,7 +128,7 @@ export class WebGLRenderer {
     this.gl = gl;
     if (!gl) {
       // fail, not able to get a context
-      throw new Error('This browser does not support WebGL. Try using the Canvas 2D.');
+      throw new Error('Error creating WebGL context');
     }
     this.initRegistry();
     this.glContextId = window.PhaserRegistry.GL_CONTEXT_ID;

src/phaser/display/webgl/util.js

@@ -19,9 +19,10 @@ export function compileShader(gl, shaderSrc, shaderType) {
   gl.shaderSource(shader, src);
   gl.compileShader(shader);
   if (!gl.getShaderParameter(shader, gl.COMPILE_STATUS)) {
-    if (window.PhaserRegistry) {
-      window.PhaserRegistry.GL_SHADER_INFO_LOG = gl.getShaderInfoLog(shader);
+    if (!window.PhaserRegistry) {
+      window.PhaserRegistry = {};
     }
+    window.PhaserRegistry.GL_SHADER_INFO_LOG = gl.getShaderInfoLog(shader);
     return null;
   }
   return shader;
@@ -65,9 +66,10 @@ export function compileProgram(gl, vertexSrc, fragmentSrc) {
   gl.linkProgram(shaderProgram);
 
   if (!gl.getProgramParameter(shaderProgram, gl.LINK_STATUS)) {
-    if (window.PhaserRegistry) {
-      window.PhaserRegistry.GL_PROGRAM_INFO_LOG = gl.getProgramInfoLog(shaderProgram);
+    if (!window.PhaserRegistry) {
+      window.PhaserRegistry = {};
     }
+    window.PhaserRegistry.GL_PROGRAM_INFO_LOG = gl.getProgramInfoLog(shaderProgram);
   }
   return shaderProgram;
 }

src/phaser/geom/util/point.js

@@ -248,7 +248,7 @@ export function centroid(points, output = null) {
   const result = output || new Point();
   const pointsLen = points.length;
   if (pointsLen < 1) {
-    throw new Error('Point(points) array must not be empty.');
+    throw new Error('Point(points) array must not be empty');
   }
   if (pointsLen === 1) {
     result.copyFrom(points[0]);