Add Integratord options tag IT support #4166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
May 15, 2023
36 tasks
damarisg
requested changes
May 30, 2023
tests/integration/test_integratord/test_integration_options/test_pagerduty_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_shuffle_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_slack_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_slack_options.py
Outdated
Show resolved
Hide resolved
TomasTurina
force-pushed
the
3928-integration-option-it-support
branch
from
fe0d010
to
401a7ac
Compare
TomasTurina
force-pushed
the
3928-integration-option-it-support
branch
from
401a7ac
to
ed74782
Compare
TomasTurina
previously approved these changes
Jul 14, 2023
damarisg
requested changes
Jul 14, 2023
tests/integration/test_integratord/test_integration_options/test_pagerduty_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_pagerduty_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_shuffle_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_shuffle_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_slack_options.py
Outdated
Show resolved
Hide resolved
tests/integration/test_integratord/test_integration_options/test_slack_options.py
Outdated
Show resolved
Hide resolved
TomasTurina
approved these changes
Jul 14, 2023
damarisg
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Issue adds support for the new Slack integration
optionstag. This tag allows passing custom JSON string that will be sent as part of the message to the integration and/or replace values with the ones configured. The PR adds 20 test cases for different configurations and values.Added
test_integratord/test_integration_options/test_slack_options.pytest_integratord/test_integration_options/test_shuffle_options.pytest_integratord/test_integration_options/test_pagerduty_options.pyTesting performed