Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add unused event #41

Merged
merged 1 commit into from
Jul 17, 2023
Merged

chore: add unused event #41

merged 1 commit into from
Jul 17, 2023

Conversation

webbertakken
Copy link
Owner

Changes

  • Add unused event

Checklist

  • Read the contribution guide and accept the
    code of conduct
  • Readme (updated or not needed)
  • Tests (added, updated or not needed)

@pr-code-reviewer
Copy link

👋 Hi there!

The most important things to improve in the code-diff are:

  1. Add a comment explaining the reason for skipping the 'commit_comment' event, as it was added to the list of unused events.
  2. Check if the 'event.name' exists before using it in the 'unusedEvents.includes()' statement to avoid potential errors.
  3. Consider refactoring the code to use a set or other data structure instead of an array for 'unusedEvents' to improve performance and simplify the code.


Automatically generated with the help of gpt-3.5-turbo.
Feedback? Please don't hesitate to drop me an email at [email protected].

@webbertakken webbertakken merged commit 0613d38 into main Jul 17, 2023
1 check passed
@webbertakken webbertakken deleted the list-unused-event branch July 17, 2023 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant