-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #4562: add support for internationalized email addresses #5799
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
1196339
Change definition of string equality to use 'is'/'identical to' from …
aphillips 4f14092
Fix transposed words so "identical to" reference matches.
aphillips 2b72d5b
Finished porting `case-sensitive` references to `is`|`identical to`
aphillips 80acb2e
Remove for=string from references
aphillips e955ce6
Address CI build issues (trailing spaces)
aphillips 09a1124
Missed one trailing space
aphillips b0c06b9
Address @annevk's comments
aphillips fb0e1b1
Point people directly to Infra
domenic 433ecd9
Fixed CI issue (used a 2119 keyword in a note)
aphillips 7e4a89b
Merge branch 'master' of https://github.com/aphillips/html
aphillips b6ccfb5
Remove note again
domenic ecd6ef8
formatting and minor editorial changes
annevk ad07c4d
A couple minor nits
domenic ee8c480
Merge remote-tracking branch 'whatwg/master'
aphillips 9d4e530
Merge remote-tracking branch 'whatwg/master'
aphillips 3ae2cc9
Fix #4562. Adds support for internationalized email addresses to inpu…
aphillips 6d6e20c
Address wattsi error (failed to remove close div)
aphillips fcea2b1
Repair missing link and add reference to RFC6531.
aphillips 17d2eef
Fixed CI errors.
aphillips 5f8f396
Really actually strip trailing spaces.
aphillips 86b9335
Strip one missing trailing space
aphillips File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The valid host string rule is not compatible with RFC 5321, section 4.1.2. In SMTP, IPv4 addresses must be wrapped in square brackets, e.g.
mailbox@[10.0.0.1]
.I just verified that Postfix enforces this rule.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The currently published spec forbids the use of IP addresses in the domain part anyway. We could just keep recommending that. If we do, then this is sufficient, I think:
https://url.spec.whatwg.org/#valid-domain (which is correct for IDNA, but also see whatwg/url#245).