Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WFLY-19315 xmlns entries migration #905

Merged
merged 5 commits into from
May 17, 2024

Conversation

ritonglue
Copy link

Copy link

openshift-ci bot commented May 8, 2024

Hi @ritonglue. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@emmartins
Copy link
Contributor

thanks @ritonglue , I enabled the CI to ensure the changes work as expected. I may take a week or so to merge it tho, cause we are in the process of merging the glow-preview branch, which is a big and more complex than usual task. I will let you know once I resume merging other PRs

@ritonglue
Copy link
Author

I don't understand why there are some checks "not successful". For example the microprofile-openapi works as expected. Do the ckecks succeeds in the main branch ?

@emmartins
Copy link
Contributor

emmartins commented May 10, 2024

Sometimes a test run fails, due to GH issues, anyway it's only problematic if you see a full matrix for a specific quickstart failing, that is an indicator something is wrong.

I have restarted the 2 fails.

PS: please ignore the openshift one, we are reworking that

PS: for each quickstart we run 2 matrix for the sources on your branch, the standard build, which uses WildFly version in pom.xmls, usually the latest released; and the build with deps, a build where we use instead the main branch of WildFly.

@ritonglue ritonglue force-pushed the WFLY-19315_xmlns_entries_migration branch 2 times, most recently from d9216fd to 222d6e6 Compare May 12, 2024 13:30
@emmartins
Copy link
Contributor

hi @ritonglue , can you please rebase this PR? thanks in advance

@ritonglue ritonglue force-pushed the WFLY-19315_xmlns_entries_migration branch from 222d6e6 to b3f1bf0 Compare May 16, 2024 08:20
@emmartins emmartins merged commit 4c36d46 into wildfly:main May 17, 2024
299 checks passed
@emmartins
Copy link
Contributor

thank you @ritonglue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants