[FE] 생성페이지 달력, 시간 입력 리팩토링(#603) #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
00kang
approved these changes
Oct 17, 2024
| @@ -6,7 +6,7 @@ export const TimeDropdownContainer = styled.section` | |||
| width: 100px; | |||
| `; | |||
|
|
|||
| export const TimeDropdownToggle = styled.input<{ $error: boolean }>` | |||
There was a problem hiding this comment.
제출 시간보다 이전 시간을 선택하면 error 상태로 판단할 수 있을 것 같아요!
아직 방 생성과 수정이 오픈되지 않는 기능이라 추후에 반영하면 좋을 것 같아요
There was a problem hiding this comment.
문구랑 함께 띄워주면 좋을 것 같네요 ! 퍼블릭 기능으로 전환할 때 참고하겠습니다~~
Comment on lines
-36
to
-39
| const [recruitmentDate, setRecruitmentDate] = useState(new Date()); | ||
| const [reviewDate, setReviewDate] = useState(new Date()); | ||
| const [recruitmentTime, setRecruitmentTime] = useState(new Date()); | ||
| const [reviewTime, setReviewTime] = useState(new Date()); |
There was a problem hiding this comment.
ㅋㅋㅋㅋㅋㅋㅋ사라져서 다행이에요........
pp449
approved these changes
Oct 17, 2024
Comment on lines
+60
to
+61
| export const formatCombinedDateTime = (date: Date): string => { | ||
| return `${formatDate(date)} ${formatTime(date)}`; |
| @@ -218,10 +188,12 @@ const RoomCreatePage = () => { | |||
| <S.ContentInput> | |||
| <Input | |||
| type="number" | |||
| min="1" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
DateTimePicker라는 컴포넌트를 만들어서 달력과 시간을 한 번에 입력 받도록 하였습니다.CreateRoomPage전체적으로 리팩토링 하였습니다. (handleInputChange 함수 간소화, isFormValid 변수 추가)