[FE] 방 수정 기능 추가(#616) #620
Open
+145
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
youngsu5582
approved these changes
Oct 17, 2024
frontend/src/@types/roomInfo.ts
Outdated
| } | ||
|
|
||
| export interface SubmitRoomInfo extends BaseRoomInfo { | ||
| id?: number; |
There was a problem hiding this comment.
roomId 인데 방 생성할 땐 roomId가 필요 없습니다.
(본인이 만들어 주셨어요🤗)
| @@ -12,7 +12,7 @@ const sampleRoomList = { | |||
| | "MANAGER" | |||
| | "PULL_REQUEST_NOT_SUBMITTED", | |||
| memberRole: roomInfo.memberRole as "BOTH" | "REVIEWER" | "REVIEWEE" | "NONE", | |||
| message: "FAIL시 오류 메시지", | |||
| classification: roomInfo.classification as "ALL" | "FRONTEND" | "BACKEND" | "ANDROID", | |||
There was a problem hiding this comment.
왜 의도적으로 as 를 사용해서 변환하는지
There was a problem hiding this comment.
json 데이터는 타입을 인식하지 못 해서 타입 단언해 주어야 합니다. (프론트한테 와서 왜 이러세요🤩👍)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 스토리북 링크
바로가기
📌 관련 이슈
✨ PR 세부 내용
RoomFormLayout으로 옮겼습니다