Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refresh token expiration 변경 #694

Merged
merged 1 commit into from
Oct 11, 2024
Merged

feat: refresh token expiration 변경 #694

merged 1 commit into from
Oct 11, 2024

Conversation

mzeong
Copy link
Contributor

@mzeong mzeong commented Oct 10, 2024

🚩 연관 이슈

close #693


📝 작업 내용

차람의 요청에 따라 리프레시 토큰의 유효기간을 아래와 같이 수정합니다

기존 변경
86,400,000 = 60 * 60 * 24 (1일) 2,419,200,000 = 86,400,000 * 7 * 4 (4주)

🏞️ 스크린샷 (선택)


🗣️ 리뷰 요구사항 (선택)

Copy link

github-actions bot commented Oct 10, 2024

Test Results

156 tests   156 ✅  6s ⏱️
 45 suites    0 💤
 45 files      0 ❌

Results for commit 3eeb24a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Oct 10, 2024

📝 Test Coverage Report

Overall Project 79.96%

There is no coverage information present for the Files changed

Copy link
Contributor

@eun-byeol eun-byeol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

만료기간 변경 이유가 무엇이었나요?🤔

@hyeon0208
Copy link
Contributor

hyeon0208 commented Oct 11, 2024

만료기간 변경 이유가 무엇이었나요?🤔

22

close 시 Dev 배포 스크립트 도는 문제

실수로 제리 PR을 close 했더니 close 만으로도 배포 스크립트가 돌더라구요
prod 처럼 PR이 머지 됐을 때 스크립트가 돌도록 이 부분만 추가 수정 부탁드립니다 🙇🏼‍♂️🙇🏼‍♂️🙇🏼‍♂️🙇🏼‍♂️

@hyeon0208 hyeon0208 closed this Oct 11, 2024
@hyeon0208 hyeon0208 reopened this Oct 11, 2024
@mzeong
Copy link
Contributor Author

mzeong commented Oct 11, 2024

@eun-byeol @hyeon0208

리프레시 토큰이 만료되었다는 에러를 발생시키면 안드 측에서 모든 화면에서 로그인 화면으로 네비게이트해줘야 하는데 이 작업이 번거롭다고 합니다. 그래서 리프레시 토큰 기한을 늘리는 방안으로 대처하고 싶다고 합니다!

@coli-geonwoo coli-geonwoo merged commit 21ffdab into develop Oct 11, 2024
4 checks passed
@coli-geonwoo coli-geonwoo deleted the feature/693 branch October 11, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: refresh token expiration 변경
4 participants