refactor: BindingFragment에서 analytics 가능하게 수정 #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprilgom
approved these changes
Oct 11, 2024
|
|
||
| abstract class BindingFragment<T : ViewDataBinding>( | ||
| @LayoutRes private val layoutRes: Int, | ||
| ) : Fragment() { | ||
| private var _binding: T? = null | ||
| protected val binding: T | ||
| get() = requireNotNull(_binding) | ||
| private val analyticsHelper: AnalyticsHelper by lazy { |
There was a problem hiding this comment.
private로 해두면 BindingFragment를 상속받는 Fragment들이 analyticsHelper를 못쓸 것 같아요
There was a problem hiding this comment.
이 친구도 hilt로 주입받아보는건 어떤가요 모듈 만들어놓은거로
There was a problem hiding this comment.
BindingActivity에도 이 코드가 있나요
There was a problem hiding this comment.
hilt로 주입하려고 했는데 타입 파라미터를 알 수 없는 곳에는 못한다고 하네요ㅜㅡㅜ
There was a problem hiding this comment.
BindingActivity에는 없습니다.
There was a problem hiding this comment.
analyticsHelper에 있는 private 제거했습니다. 5b36b92
There was a problem hiding this comment.
hilt로 주입하려고 했는데 타입 파라미터를 알 수 없는 곳에는 못한다고 하네요ㅜㅡㅜ
😢
aprilgom
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #554
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)