feat: 다크모드 적용 #737
Merged
feat: 다크모드 적용 #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
스플래시와 로그인화면 다크모드는 제가 해야겠군요 |
aprilgom
approved these changes
Oct 16, 2024
kimhm0728
requested changes
Oct 17, 2024
There was a problem hiding this comment.
우왕 변경사항 많네요 정말 고생하셨습니다!!
라이트모드에서 기존 디자인과 달라진 부분, 다크모드에서 어색한 부분이 있어서 아래에 남겨두겠습니다.
원래는 아이템 backgrouond 컬러가 흰색이에요!
TimePicker 시간 위에 보라색 부분 purple_800이 아닌 purple_300입니다!
"를 입력해주세요" 텍스트 컬러가 너무 흐려서 잘 안보이는 것 같아요. 그리고 다른 입력폼의 텍스트 컬러는 white인데 여기만 gray라서 통일해주면 좋을 것 같습니다!
kimhm0728
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 연관 이슈
close #641
📝 작업 내용
🏞️ 스크린샷 (선택)
🗣️ 리뷰 요구사항 (선택)
앱 실행시켜서 다크모드로 바꾸고 체크해주세요!
이 pr 머지된뒤 부터 디자인이 추가되면 피그마에 두 가지 디자인해주시고 다크테마 항상 생각해주세요!