Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand property tests #373

Merged
merged 7 commits into from
Jul 28, 2024
Merged

Expand property tests #373

merged 7 commits into from
Jul 28, 2024

Conversation

dcherian
Copy link
Collaborator

@dcherian dcherian commented Jul 25, 2024 •
edited
Loading

Closes #29

  1. Adds coverage for first and last.
  2. Fixes not_overflowing_array to work with NaNs! This is a big one.
  3. Add more array dtypes to more tests.
  4. Turns out bfill was quite broken!
  5. refactor out hypothesis strategies

@dcherian dcherian marked this pull request as ready for review July 27, 2024 03:31
Base automatically changed from scans to main July 27, 2024 04:12
@dcherian dcherian changed the title Add first, last property test Expand property tests Jul 27, 2024
dcherian
dcherian commented Jul 27, 2024
View reviewed changes
tests/strategies.py Outdated Show resolved Hide resolved
@dcherian dcherian force-pushed the test-first-last branch 3 times, most recently from c95441e to 08c3bcf Compare July 28, 2024 13:22
@dcherian dcherian enabled auto-merge (squash) July 28, 2024 14:18
@dcherian dcherian disabled auto-merge July 28, 2024 14:18
@dcherian
Type strategies
39d8dcf
@dcherian
Fix overflowing skipping to handle NaNs
f752309 
Remove from ffill, bfill

Fix fill_value for datetime64

isnan to isnull
@dcherian
Fix ffill, bfill bugs
84cb5d8
@dcherian dcherian enabled auto-merge (rebase) July 28, 2024 14:20
@dcherian
Testing improvements.
b30ea75 
1. Record duration
2. Speed up some tests
3. Silence logging
@dcherian dcherian disabled auto-merge July 28, 2024 20:13
@dcherian
Copy link
Collaborator Author

Failure fixed on ml31415/numpy-groupies#90

@dcherian dcherian merged commit 1a53cd1 into main Jul 28, 2024
14 of 15 checks passed
@dcherian dcherian deleted the test-first-last branch July 28, 2024 20:13
@dcherian dcherian restored the test-first-last branch July 28, 2024 20:14
@dcherian dcherian deleted the test-first-last branch July 28, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for first, last
1 participant
@dcherian