-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[service.games.discord.richpresence] 1.0.0 #2267
base: nexus
Are you sure you want to change the base?
Conversation
53ec2cc
to
f15fcfd
Compare
<extension point="xbmc.service" library="default.py" /> | ||
<extension point="xbmc.addon.metadata"> | ||
<platform>all</platform> | ||
<source>https://github.com/NikosSiak/service.games.discord.richpresence</source> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing description and summary (en_GB), missing license (spdx identifier). See example: https://github.com/xbmc/xbmc/blob/master/addons/service.xbmc.versioncheck/addon.xml
@@ -0,0 +1,37 @@ | |||
import xbmc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually it's a good practice to keep this file (as the main entrypoint) as small as possible. Reason is the fact this is the only file that is not compiled to bytecode.
Can you move this to resources/lib/richpresence.py
and in this file simply import and run?
from resources.lib.richpresence import mystuff
mystuff.run()
There's a warning for this in addon checker
startTime = -1 | ||
gameStarted = False | ||
|
||
while True: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while not monitor.abortRequested():
if monitor.abortRequested():
break
your stuff
monitor.waitForAbort(5)
f15fcfd
to
4be8681
Compare
4be8681
to
d333bfa
Compare
@@ -0,0 +1,99 @@ | |||
import os |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the dummy __init__.py
is no longer needed in python3, can you drop it from the submission?
Description
This addon will display what game are you playing and what you are doing in the game at this moment. This is based on the xbmc/xbmc#21286 PR
Checklist:
Additional information :