Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skin.aeon.nox.silvo] v9.1.5 #442

Merged
merged 1 commit into from
Apr 14, 2024
Merged

[skin.aeon.nox.silvo] v9.1.5 #442

merged 1 commit into from
Apr 14, 2024

Conversation

MikeSiLVO
Copy link

Description

  • Fix navigation issue in Music OSD settings[
  • Add SceneMarkers, Cuts, & Editlist markers to seekbar
  • Add trakt comments to recommendations dialog
  • Tweaks to channel Wall for PVR
  • Some Live Background fixes thx davewuk

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

@MikeSiLVO MikeSiLVO force-pushed the nox_nexus branch 2 times, most recently from eb7a747 to ac3d332 Compare April 14, 2024 17:42
@ronie
Copy link
Member

ronie commented Apr 14, 2024

could you please have a look at these?

Variable not defined: DialogSelectLabel2RuntimeVar
16x9/Variables.xml: line 369

Variable not defined: DialogSelectLabel2RuntimeVar
16x9/Variables.xml: line 370

Variable not defined: DialogSelectLabel2RuntimeVar
16x9/Variables.xml: line 371

Variable not defined: StarRatingFocusedDiffuseVar
16x9/View_50_List.xml: line 1512

Control / Item ID not defined: 50012
16x9/Variables.xml: line 1482

@MikeSiLVO
Copy link
Author

Darn it, some Omega only things sneaked in there. Will update asap thanks

@MikeSiLVO
Copy link
Author

Had some cherry pick from master branch gobbledygook but it should all be fixed now :)

@ronie
Copy link
Member

ronie commented Apr 14, 2024

great, thx!

@ronie ronie merged commit 8faa04d into xbmc:nexus Apr 14, 2024
1 check passed
@MikeSiLVO MikeSiLVO deleted the nox_nexus branch June 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants