Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pkg-config for including shared libzmq #641

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use pkg-config for including shared libzmq #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion binding.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@

["zmq_shared == 'true'", {
'link_settings': {
'libraries': ['-lzmq'],
'ldflags': [
'<!(pkg-config --libs-only-other --libs-only-L libzmq)'
],
'libraries': [
'<!(pkg-config --libs-only-l libzmq)'
],
Comment on lines +67 to +72
Copy link
Member

@aminya aminya Jul 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be guarded for platforms that do not ship pkg-config (e.g. Windows). Also, on Windows, the library is probably called zmq not libzmq

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense. Will look into it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any updates on this? @jirijakes

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delayed response.

I have not got to it yet but still plan to within next few weeks. Is it okay to keep the PR open in the meantime?

},
}, {
'conditions': [
Expand Down
Loading