Include local mining fees for pure liquidity purchases #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we are purchasing liquidity without any other splice operation (splice-in, splice-out or splice-cpfp), we will have a single entry in our DB: the liquidity purchase itself. In that case, we are paying mining fees for the shared input and output: we must record those in the purchase. This happens during manual liquidity purchases and on-the-fly funding. We cannot easily add tests because we don't implement the liquidity seller side, which makes it hard to trigger those conditions.
This is used in the case where there is no other payment entry to account for local mining fees.
pm47
approved these changes
Oct 9, 2024
dpad85
added a commit
to ACINQ/phoenixd
that referenced
this pull request
Oct 10, 2024
With ACINQ/lightning-kmp#709 and ACINQ/lightning-kmp#710, the mining fee for liquidity events is split between local and purchase fee. However, we don't directly store the split fees, for backward compatibility reasons. Thus, to get the local fee from the database, we must compute it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we are purchasing liquidity without any other splice operation (splice-in, splice-out or splice-cpfp), we will have a single entry in our DB: the liquidity purchase itself. In that case, we are paying mining fees for the shared input and output: we must record those in the purchase. This happens during manual liquidity purchases and on-the-fly funding.
We cannot easily add tests because we don't implement the liquidity seller side, which makes it hard to trigger those conditions.