Small refactor & update in modlist.menu, server_browser.menu #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs testing
ASpoonPlaysGames
approved these changes
Sep 8, 2024
ASpoonPlaysGames
removed
the
needs code review
Alystrasz
reviewed
Sep 9, 2024
Alystrasz
reviewed
Sep 10, 2024
| @@ -407,11 +407,11 @@ resource/ui/menus/modlist.menu | |||
|
|
|||
| labelText "#CLEAR_FILTERS" | |||
| wide 100 | |||
| xpos -15 | |||
| ypos -55 | |||
| xpos 0 | |||
There was a problem hiding this comment.
What does this change for the mod list button?
I don't see any change with and without the PR:
Without
With
| @@ -2554,6 +2554,7 @@ resource/ui/menus/mods_browse.menu | |||
| xpos -17 | |||
| ypos -57 | |||
| zpos 90 | |||
| textAlignment north | |||
There was a problem hiding this comment.
I wanted to suggest center for this parameter, but the resulting position is the same as north it seems ¯\_(ツ)_/¯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update modlist.menu
Refactor
Doesnt change visuals
Update server_browser.menu
Makes text in "Join" button allign to middle/north which looks better