Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several frontend fixes #505

Merged
merged 17 commits into from
Jul 14, 2023
Merged

Several frontend fixes #505

merged 17 commits into from
Jul 14, 2023

Conversation

kstam
Copy link
Collaborator

@kstam kstam commented Jul 10, 2023

  • Fix issue cause by out of order messages
  • Improve shot graph responsiveness
  • Also implemented Settings
image image image
  • And better profile preview
image
  • And profile editing v1
image

Copy link

@ckifer ckifer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

bunch of nit comments about defaultProps but looks good!

webserver/web-interface/src/components/chart/StatBox.tsx Outdated Show resolved Hide resolved
webserver/web-interface/src/components/chart/StatBox.tsx Outdated Show resolved Hide resolved
webserver/web-interface/src/components/chart/StatBox.tsx Outdated Show resolved Hide resolved
webserver/web-interface/src/components/chart/StatBox.tsx Outdated Show resolved Hide resolved
webserver/web-interface/src/components/chart/StatBox.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 35 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Zer0-bit Zer0-bit merged commit 80680d7 into dev Jul 14, 2023
6 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants