Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster M4sk: user control of eyes, user config from config.eye, user wiichuck control eyes&neopixels #915

Open
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

TonyLHansen
Copy link

M4_Eyes.ino: add a set of user_callable functions to control the eyes: eyesWide, eyesBlink, eyesToCorner, eyesNormal

file.cpp: add additional user_setup function that passes in the configuration
file.cpp: add some accessor functions that use dwim()
globals.h: declarations of new functions
user_watch.cpp: fix case on HeatSensor.h for case-sensitive compilation systems
user_watch.cpp: convert to using new eyesToCorner()
user_*.cpp: add user_setup(doc) function
new user_wiichuck.cpp: connects to WiiChuck that controls eyes and NeoPixel strip

…: eyesWide, eyesBlink, eyesToCorner, eyesNormal

file.cpp: add additional user_setup function that passes in the configuration
file.cpp: add some accessor functions that use dwim()
globals.h: declarations of new functions
user_watch.cpp: fix case on HeatSensor.h for case-sensitive compilation systems
user_watch.cpp: convert to using new eyesToCorner()
user_*.cpp: add user_setup(doc) function
new user_wiichuck.cpp: connects to WiiChuck that controls eyes and NeoPixel strip
@TonyLHansen TonyLHansen changed the title user control of eyes, user config from config.eye, user wiichuck control eyes&neopixels Monster M4sk: user control of eyes, user config from config.eye, user wiichuck control eyes&neopixels Nov 15, 2019
@TonyLHansen
Copy link
Author

@ladyada, can another reviewer be assigned to this PR?

@ladyada
Copy link
Member

ladyada commented Dec 22, 2019

hi, there's no other reviewers available, we don't have guaranteed ETAs for merging contributor projects. thank u!

@TonyLHansen
Copy link
Author

@ladyada Thanks for the reply; I figured it was worth asking. I’ll keep rebasing the PR once in a while until it gets merged.

Added additional eye functions (close, wide), to replace boop and blink functions on the Wiichuck button functions for better eye puppetry. Other minor style and debugging changes.
Additional eye type for eagles and other birds of prey. Eyelids are *inverted*, eagles blink up as their top eyelid is larger than the bottom one!
Improved configuration documentation of eagle eyes. Minor updates to debugging output.
@evaherrada evaherrada changed the base branch from master to main June 10, 2021 20:50
@TheKitty
Copy link
Collaborator

This one isn't passing lint checks

Fixes to wiichuck support and upstream compilation checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants