Adding router v2 #7392
Open
Adding router v2 #7392
+179
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
requested review from
colin-axner,
AdityaSripal,
damiannolan,
crodriguezvega,
DimitrisJim,
gjermundgaraba and
bznein
as code owners
bznein
approved these changes
Oct 3, 2024
| } | ||
|
|
||
| if rtr.HasRoute(module) { | ||
| panic(errors.New(fmt.Sprintf("route %s has already been registered", module))) |
There was a problem hiding this comment.
(just curious: why do we panic with errors.New here rather than just fmt.Sprintf, as we do at line 41?)
There was a problem hiding this comment.
most panics (I think all) use errors rather than strings, so this was just to be consistent.
modules/core/api/router.go
Outdated
|
|
||
| // it's possible that some routes have been dynamically added e.g. with interchain accounts. | ||
| // in this case, we need to check if the module has the specified prefix. | ||
| for prefix := range rtr.routes { |
There was a problem hiding this comment.
[nit] since rtr.routes is a map, can't we loop like this?
for prefix, value := range rtr.routes {
if strings.HasPrefix(module, prefix) {
return value, true
}
}?
modules/core/api/router_test.go
Outdated
| mockv2 "github.com/cosmos/ibc-go/v9/testing/mock/v2" | ||
| ) | ||
|
|
||
| func (suite *ApiTestSuite) TestRouteer() { |
There was a problem hiding this comment.
Suggested change
| func (suite *ApiTestSuite) TestRouteer() { | |
| func (suite *ApiTestSuite) TestRouter() { |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Also adding barebones mock module to have an implementation of the interface to register.
closes: #7384
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.