-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding router v2 #7392
Open
chatton
wants to merge
2
commits into
feat/ibc-eureka
Choose a base branch
from
cian/issue#7384-add-port-router-v2
base: feat/ibc-eureka
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Adding router v2 #7392
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package api_test | ||
|
||
import ( | ||
testifysuite "github.com/stretchr/testify/suite" | ||
"testing" | ||
) | ||
|
||
type ApiTestSuite struct { | ||
Check failure on line 8 in modules/core/api/api_test.go GitHub Actions / lint
|
||
testifysuite.Suite | ||
} | ||
|
||
func TestApiTestSuite(t *testing.T) { | ||
testifysuite.Run(t, new(ApiTestSuite)) | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
package api | ||
|
||
import ( | ||
"errors" | ||
"fmt" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
"strings" | ||
) | ||
|
||
// Router contains all the module-defined callbacks required by IBC Protocol V2. | ||
type Router struct { | ||
routes map[string]IBCModule | ||
} | ||
|
||
// NewRouter creates a new Router instance. | ||
func NewRouter() *Router { | ||
return &Router{ | ||
routes: make(map[string]IBCModule), | ||
} | ||
} | ||
|
||
// AddRoute registers a route for a given module name. | ||
func (rtr *Router) AddRoute(module string, cbs IBCModule) *Router { | ||
if !sdk.IsAlphaNumeric(module) { | ||
panic(errors.New("route expressions can only contain alphanumeric characters")) | ||
} | ||
|
||
if rtr.HasRoute(module) { | ||
panic(errors.New(fmt.Sprintf("route %s has already been registered", module))) | ||
Check failure on line 29 in modules/core/api/router.go GitHub Actions / lint
|
||
} | ||
|
||
rtr.routes[module] = cbs | ||
|
||
return rtr | ||
} | ||
|
||
// Route returns the IBCModule for a given module name. | ||
func (rtr *Router) Route(module string) IBCModule { | ||
route, ok := rtr.routeOrPrefixedRoute(module) | ||
if !ok { | ||
panic(fmt.Sprintf("no route for %s", module)) | ||
} | ||
return route | ||
} | ||
|
||
// HasRoute returns true if the Router has a module registered or false otherwise. | ||
func (rtr *Router) HasRoute(module string) bool { | ||
_, ok := rtr.routeOrPrefixedRoute(module) | ||
return ok | ||
} | ||
|
||
// routeOrPrefixedRoute returns the IBCModule for a given module name. | ||
// if an exact match is not found, a route with the provided prefix is searched for instead. | ||
func (rtr *Router) routeOrPrefixedRoute(module string) (IBCModule, bool) { | ||
route, ok := rtr.routes[module] | ||
if ok { | ||
return route, true | ||
} | ||
|
||
// it's possible that some routes have been dynamically added e.g. with interchain accounts. | ||
// in this case, we need to check if the module has the specified prefix. | ||
for prefix, ibcModule := range rtr.routes { | ||
if strings.HasPrefix(module, prefix) { | ||
return ibcModule, true | ||
} | ||
} | ||
return nil, false | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
package api_test | ||
|
||
import ( | ||
"github.com/cosmos/ibc-go/v9/modules/core/api" | ||
mockv2 "github.com/cosmos/ibc-go/v9/testing/mock/v2" | ||
) | ||
|
||
func (suite *ApiTestSuite) TestRouter() { | ||
var router *api.Router | ||
|
||
var testCases = []struct { | ||
name string | ||
malleate func() | ||
assertionFn func() | ||
}{ | ||
{ | ||
name: "success", | ||
malleate: func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
}, | ||
assertionFn: func() { | ||
suite.Require().True(router.HasRoute("module01")) | ||
}, | ||
}, | ||
{ | ||
name: "success: multiple modules", | ||
malleate: func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
router.AddRoute("module02", &mockv2.IBCModule{}) | ||
router.AddRoute("module03", &mockv2.IBCModule{}) | ||
}, | ||
assertionFn: func() { | ||
suite.Require().True(router.HasRoute("module01")) | ||
suite.Require().True(router.HasRoute("module02")) | ||
suite.Require().True(router.HasRoute("module03")) | ||
}, | ||
}, | ||
{ | ||
name: "success: find by prefix", | ||
malleate: func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
}, | ||
assertionFn: func() { | ||
suite.Require().True(router.HasRoute("module01-foo")) | ||
}, | ||
}, | ||
{ | ||
name: "failure: panics on duplicate module", | ||
malleate: func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
}, | ||
assertionFn: func() { | ||
suite.Require().PanicsWithError("route module01 has already been registered", func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
}) | ||
}, | ||
}, | ||
{ | ||
name: "failure: panics invalid-name", | ||
malleate: func() { | ||
router.AddRoute("module01", &mockv2.IBCModule{}) | ||
}, | ||
assertionFn: func() { | ||
suite.Require().PanicsWithError("route expressions can only contain alphanumeric characters", func() { | ||
router.AddRoute("module-02", &mockv2.IBCModule{}) | ||
}) | ||
}, | ||
}, | ||
} | ||
for _, tc := range testCases { | ||
tc := tc | ||
|
||
suite.Run(tc.name, func() { | ||
router = api.NewRouter() | ||
|
||
tc.malleate() | ||
|
||
tc.assertionFn() | ||
}) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package mock | ||
|
||
import ( | ||
"context" | ||
sdk "github.com/cosmos/cosmos-sdk/types" | ||
channeltypesv2 "github.com/cosmos/ibc-go/v9/modules/core/04-channel/v2/types" | ||
"github.com/cosmos/ibc-go/v9/modules/core/api" | ||
) | ||
|
||
var _ api.IBCModule = (*IBCModule)(nil) | ||
|
||
type IBCModule struct{} | ||
|
||
func (I IBCModule) OnSendPacket(ctx context.Context, sourceID string, destinationID string, sequence uint64, data channeltypesv2.PacketData, signer sdk.AccAddress) error { | ||
Check failure on line 14 in testing/mock/v2/ibc_module.go GitHub Actions / lint
|
||
panic("implement me") | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just curious: why do we panic with
errors.New
here rather than justfmt.Sprintf
, as we do at line 41?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most panics (I think all) use errors rather than strings, so this was just to be consistent.