Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Docker development environment #1337

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ojeytonwilliams
Copy link
Contributor

This should make it a little easier to get started as a new contributor, as well as cut out 'works on my machine' bugs.

@freeCodeCamp/devdocs let me know what you think. Does this all work as you expect?

@@ -12,7 +12,8 @@ Want to contribute? Great. Please review the following guidelines carefully and
6. [Updating existing documentations](#updating-existing-documentations)
7. [Other contributions](#other-contributions)
8. [Coding conventions](#coding-conventions)
9. [Questions?](#questions)
9. [Developing in Docker](#developing-in-docker)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section is missing in the file (has not been committed)?

.env Outdated
@@ -0,0 +1,2 @@
USER_ID=1000
GROUP_ID=1000
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe include a comment # for Dockerfile-dev?

@@ -0,0 +1,13 @@
version: '3.7'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we already have two Dockerfiles for running devdocs in production, I would not expect docker-compose.yml to be meant for development only.

# a temporary directory to hold the lock files while the gems are installed.
WORKDIR /devdocs/

COPY Gemfile Gemfile.lock Rakefile /devdocs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running docker build - < Dockerfile-dev failed:

Step 9/14 : COPY Gemfile Gemfile.lock Rakefile /devdocs/
COPY failed: stat /var/lib/docker/tmp/docker-builder202400793/Gemfile: no such file or directory

(Not exactly sure how it is meant to be used, though…)

@ojeytonwilliams
Copy link
Contributor Author

ojeytonwilliams commented Nov 19, 2020

Thanks for the review, Simon. The latest commits should have addressed all your concerns - including adding the missing docs (thanks reflog 😓). I also moved the environment variables into a sample.env, because I never should have added .env to git!

@ojeytonwilliams
Copy link
Contributor Author

Hey @simon04, I'm still working on this. Right now using thor: upload doesn't work with AWS, so I need to figure it out.

@tsengia
Copy link

tsengia commented Jun 22, 2024

@ojeytonwilliams and @simon04 Any updates on this? I can pick this up if you'd like. I cloned the repo and started making a devcontainer... and then realized you guys already started!

@tsengia tsengia mentioned this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants