Support tinyint(1) unsigned for boolean conversion
#84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… type conversion on the Destination connector for BigQuery. Rolled back bigint change, but kept tinyint adjustment.
dbussink
reviewed
Oct 17, 2023
dbussink
reviewed
Oct 17, 2023
| @@ -7,7 +7,6 @@ import ( | |||
| "net/http" | |||
| "strings" | |||
| "time" | |||
|
|
|||
There was a problem hiding this comment.
Can you add back the line here to reduce the diff? And in general, these get formatted with an stdlib block first etc.
There was a problem hiding this comment.
I will add back the line. I am unclear about what you mean with the other sentence.
dbussink
reviewed
Oct 17, 2023
dbussink
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #83