Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

High resolution scrolling (without feature report parsing) #24423

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

eynsai
Copy link

@eynsai eynsai commented Sep 22, 2024

Description

This PR contains the changes from my previous PR that are relevant to high resolution scrolling, but without parsing for feature reports. It can be merged independently.

Three additional flags are added:

  • POINTING_DEVICE_HIRES_SCROLL_ENABLE
  • POINTING_DEVICE_HIRES_SCROLL_MULTIPLIER
  • POINTING_DEVICE_HIRES_SCROLL_EXPONENT

This PR modifies QMK's USB HID descriptor to include a feature report for scroll wheel resolution and exponent.

In the event of a merge conflict with PR 24422, refer back to my previous PR which contains the merged changes.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@eynsai eynsai changed the base branch from master to develop September 22, 2024 05:21
@eynsai eynsai mentioned this pull request Sep 22, 2024
14 tasks
@eynsai eynsai force-pushed the develop-hires-scrolling-minimal branch 2 times, most recently from b7ff474 to ebd8264 Compare September 22, 2024 05:44
@eynsai eynsai force-pushed the develop-hires-scrolling-minimal branch from ebd8264 to a583ee7 Compare September 22, 2024 06:43
@eynsai eynsai force-pushed the develop-hires-scrolling-minimal branch from c18b31d to 8a08449 Compare October 12, 2024 02:33
@eynsai
Copy link
Author

eynsai commented Oct 12, 2024

Rebase after acceptance of 24422.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant