Chore/maintenance #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents an edge case where receivers could fail to follow through with the required safeTransfer from calls and prevent legitimate bids for a short time period. Has the added effect of slightly lowered gas due to not having to wait for the responding acceptance. Enables transfers without consent, but the intent here is not to prevent the user from taking destructive actions, it is to prevent the chain from a stuck state before transaction reversion. Users are still responsible for their own understanding and actions regardless
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• updates marketplace to use transferFrom
• overrides burn in RareSpaceNFT to make sure only the token owner is a…
• adds explicit gas limit to pyaments