Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/maintenance #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Chore/maintenance #3

wants to merge 3 commits into from

Commits on Apr 4, 2024

  1. updates marketplace to use transferFrom 

    this prevents an edge case where receivers could fail to follow through with the required safeTransfer from calls and prevent legitimate bids for a short time period. Has the added effect of slightly lowered gas due to not having to wait for the responding acceptance. Enables transfers without consent, but the intent here is not to prevent the user from taking destructive actions, it is to prevent the chain from a stuck state before transaction reversion. Users are still responsible for their own understanding and actions regardless
    @rymcol
    rymcol committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c9bcaf9 View commit details
    Browse the repository at this point in the history

  2. overrides burn in RareSpaceNFT to make sure only the token owner is a… 

    …ble to burn
    @rymcol
    rymcol committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    a76d66f View commit details
    Browse the repository at this point in the history

  3. adds explicit gas limit to pyaments

    @rymcol
    rymcol committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    77ee16b View commit details
    Browse the repository at this point in the history