Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

statistics: enable the new PQ #56437

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

statistics: enable the new PQ #56437

wants to merge 3 commits into from

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Oct 2, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #55906

Problem Summary:

What changed and how does it work?

This PR is based on #56435

This PR enables the new PQ by default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Oct 2, 2024
@Rustin170506 Rustin170506 force-pushed the rustin-patch-enable-the-new-pq branch 7 times, most recently from 80a9249 to 44fa69d Compare October 2, 2024 15:39
@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.22527% with 275 lines in your changes missing coverage. Please review.

Project coverage is 75.3037%. Comparing base (74034d4) to head (833b90f).

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #56437        +/-   ##
================================================
+ Coverage   73.3645%   75.3037%   +1.9391%     
================================================
  Files          1624       1647        +23     
  Lines        448069     456615      +8546     
================================================
+ Hits         328724     343848     +15124     
+ Misses        99207      91523      -7684     
- Partials      20138      21244      +1106
Flag Coverage Δ
integration 50.2252% <2.1978%> (?)
unit 72.4461% <62.2252%> (-0.0175%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 52.2663% <ø> (+6.7533%) ⬆️

@Rustin170506 Rustin170506 force-pushed the rustin-patch-enable-the-new-pq branch 2 times, most recently from d24c37e to 9e8f8e0 Compare October 2, 2024 17:23
@Rustin170506
Copy link
Member Author

/retest

@Rustin170506 Rustin170506 mentioned this pull request Oct 3, 2024
Closed
13 tasks
@Rustin170506 Rustin170506 force-pushed the rustin-patch-enable-the-new-pq branch 13 times, most recently from 56e6561 to 9dd0cbd Compare October 4, 2024 02:44
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 4, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from rustin170506 and additionally assign lance6716 for approval(Please ensuring that each of them provides their approval before proceeding). For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Rustin170506
statistics: process DML changes in the new PQ
154b135 
fix: do not maintain time window in the queue

refactor: make lint happy

docs: add FIXME

refactor: rename to rebuildWithoutLock

fix

docs: add more comments

fix

fix

fix

fix

fix

fix

fix

fix

feat: add jobHooks

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@Rustin170506
statistics: handle DDL events
f75b343 
fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@Rustin170506
statistics: enable the new PQ
833b90f 
fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix

fix
@Rustin170506 Rustin170506 mentioned this pull request Oct 5, 2024
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/planner SIG: Planner size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Rustin170506